]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (w83791d) Fix NULL pointer dereference by removing unnecessary structure field
authorNadezda Lutovinova <lutovinova@ispras.ru>
Tue, 21 Sep 2021 15:51:51 +0000 (18:51 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Oct 2021 13:42:31 +0000 (15:42 +0200)
commitf817a562d7db7b08f4dfba41a8ce40b2910fb932
tree5fd45c62a35757dc3c229ed991458e4f3f47700b
parentab20445d57aef85f7e9198d457e122ee82716277
hwmon: (w83791d) Fix NULL pointer dereference by removing unnecessary structure field

commit 943c15ac1b84d378da26bba41c83c67e16499ac4 upstream.

If driver read val value sufficient for
(val & 0x08) && (!(val & 0x80)) && ((val & 0x7) == ((val >> 4) & 0x7))
from device then Null pointer dereference occurs.
(It is possible if tmp = 0b0xyz1xyz, where same literals mean same numbers)
Also lm75[] does not serve a purpose anymore after switching to
devm_i2c_new_dummy_device() in w83791d_detect_subclients().

The patch fixes possible NULL pointer dereference by removing lm75[].

Found by Linux Driver Verification project (linuxtesting.org).

Cc: stable@vger.kernel.org
Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Link: https://lore.kernel.org/r/20210921155153.28098-1-lutovinova@ispras.ru
[groeck: Dropped unnecessary continuation lines, fixed multi-line alignment]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/w83791d.c