]> git.baikalelectronics.ru Git - kernel.git/commit
net: wwan: t7xx: Fix return type of t7xx_ccmni_start_xmit
authorNathan Huckleberry <nhuck@google.com>
Mon, 12 Sep 2022 21:45:10 +0000 (14:45 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Sep 2022 01:28:50 +0000 (18:28 -0700)
commitf7745123f9a8c196f5191116fdbdd6aeb22f9d22
tree508e859ee18ceb35ed9996658ddebe684dfd667b
parent34279155ca619371e1a20019ac1ff1c18ae8eb81
net: wwan: t7xx: Fix return type of t7xx_ccmni_start_xmit

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of t7xx_ccmni_start_xmit should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Link: https://lore.kernel.org/r/20220912214510.929070-1-nhuck@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wwan/t7xx/t7xx_netdev.c