]> git.baikalelectronics.ru Git - kernel.git/commit
MIPS: tlbex: Explicitly cast _PAGE_NO_EXEC to a boolean
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 12 Aug 2019 03:31:20 +0000 (20:31 -0700)
committerPaul Burton <paul.burton@mips.com>
Mon, 12 Aug 2019 04:44:31 +0000 (21:44 -0700)
commitf73dd2a9ea479d8ed7efd5fa9e07ba96f8b0dbbd
treebac69ce4216487aedbaf33c04eb563ad35422118
parente5d4dd772a6b11c5a1eb215dc60837a9cb0b8c9a
MIPS: tlbex: Explicitly cast _PAGE_NO_EXEC to a boolean

clang warns:

arch/mips/mm/tlbex.c:634:19: error: use of logical '&&' with constant
operand [-Werror,-Wconstant-logical-operand]
        if (cpu_has_rixi && _PAGE_NO_EXEC) {
                         ^  ~~~~~~~~~~~~~
arch/mips/mm/tlbex.c:634:19: note: use '&' for a bitwise operation
        if (cpu_has_rixi && _PAGE_NO_EXEC) {
                         ^~
                         &
arch/mips/mm/tlbex.c:634:19: note: remove constant to silence this
warning
        if (cpu_has_rixi && _PAGE_NO_EXEC) {
                        ~^~~~~~~~~~~~~~~~
1 error generated.

Explicitly cast this value to a boolean so that clang understands we
intend for this to be a non-zero value.

Fixes: ef376f4f8f5c ("MIPS: tlbex: Avoid placing software PTE bits in Entry* PFN fields")
Link: https://github.com/ClangBuiltLinux/linux/issues/609
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: clang-built-linux@googlegroups.com
arch/mips/mm/tlbex.c