]> git.baikalelectronics.ru Git - kernel.git/commit
drm/etnaviv: avoid cleaning up sched_job when submit succeeded
authorLucas Stach <l.stach@pengutronix.de>
Wed, 4 May 2022 09:02:29 +0000 (11:02 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 4 May 2022 12:09:34 +0000 (14:09 +0200)
commitf65b2c2a9bde14b71ba803b83f6ca6e7ef9fccd5
tree2951d764330c4bec1e5c202e24d7e8df3f8e2193
parentaf5c2133410b8e94a5eabaa2f377f79afd3ee4e9
drm/etnaviv: avoid cleaning up sched_job when submit succeeded

While the labels may mislead the casual reader, the tail of the function
etnaviv_ioctl_gem_submit is always executed, as a lot of the structures
set up in this function need to be cleaned up regardless of whether the
submit succeeded or failed.

An exception is the newly added drm_sched_job_cleanup, which must only
be called when the submit failed before handing the job to the
scheduler.

Fixes: 767a9e206d08 ("drm/etnaviv: Use scheduler dependency handling")
Reported-by: Michael Walle <michael@walle.cc>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220504090229.2506560-1-l.stach@pengutronix.de
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c