]> git.baikalelectronics.ru Git - kernel.git/commit
drm/fsl-dcu: Don't set connector DPMS property
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Fri, 10 Nov 2017 16:38:34 +0000 (17:38 +0100)
committerStefan Agner <stefan@agner.ch>
Tue, 14 Nov 2017 16:15:45 +0000 (17:15 +0100)
commitf60d84e5fff786719128d45c7b9aacc9f4313a63
treedc0b4eb3720802047b2e2a366320923d4600c79b
parentaca6701fc57c683d49e9ff7e2d113983ed387ea7
drm/fsl-dcu: Don't set connector DPMS property

Since commit a78e1f1bc8ae ("drm: Don't update property values for atomic
drivers") atomic drivers must not update property values as properties
are read from the state instead. To catch remaining users, the
drm_object_property_set_value() function now throws a warning when
called by atomic drivers on non-immutable properties, and we hit that
warning when creating connectors.

The easy fix is to just remove the drm_object_property_set_value() as it
is used here to set the initial value of the connector's DPMS property
to OFF. The DPMS property applies on top of the connector's state crtc
pointer (initialized to NULL) that is the main connector on/off control,
and should thus default to ON.

Fixes: a78e1f1bc8ae ("drm: Don't update property values for atomic drivers")
Cc: stable@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Stefan Agner <stefan@agner.ch>
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c