]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: x86/mmu: Remove spurious TLB flush from TDP MMU's change_pte() hook
authorSean Christopherson <seanjc@google.com>
Fri, 26 Feb 2021 01:03:25 +0000 (17:03 -0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 15 Mar 2021 08:43:29 +0000 (04:43 -0400)
commitf509062e3b9ba7110a818b2d47b59b345a24d298
treec0a4ec5731761b64c5a530eb9fc60431850a2d02
parentdb49e1a58982e33b0be472eb1a6c4dc5d3ad6869
KVM: x86/mmu: Remove spurious TLB flush from TDP MMU's change_pte() hook

Remove an unnecessary remote TLB flush from set_tdp_spte(), the TDP MMu's
hook for handling change_pte() invocations from the MMU notifier.  If
the new host PTE is writable, the flush is completely redundant as there
are no futher changes to the SPTE before the post-loop flush.  If the
host PTE is read-only, then the primary MMU is responsible for ensuring
that the contents of the old and new pages are identical, thus it's safe
to let the guest continue reading both the old and new pages.  KVM must
only ensure the old page cannot be referenced after returning from its
callback; this is handled by the post-loop flush.

Fixes: e425cff6e71b ("kvm: x86/mmu: Support changed pte notifier in tdp MMU")
Cc: Ben Gardon <bgardon@google.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20210226010329.1766033-2-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu/tdp_mmu.c