]> git.baikalelectronics.ru Git - kernel.git/commit
arch/sh/drivers/dma/dma-sh.c: Correct use of ! and &
authorJulia Lawall <julia@diku.dk>
Tue, 26 Feb 2008 20:42:11 +0000 (21:42 +0100)
committerPaul Mundt <lethal@linux-sh.org>
Wed, 27 Feb 2008 01:28:48 +0000 (10:28 +0900)
commitf4f2807937688cd16bee9a17b8ed58f443bba57a
treefe2f07da02b84c66388cfe6c2483170932a49bb5
parenta4c582e4f8a38932f4e3d352b409c260cdabb799
arch/sh/drivers/dma/dma-sh.c: Correct use of ! and &

In commit fbb1ccd43b0dfa2ef851295f09c104022e4e2c88, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
arch/sh/drivers/dma/dma-sh.c