]> git.baikalelectronics.ru Git - kernel.git/commit
brcmfmac: add missing curly braces in brcmf_fws_txstatus_suppressed()
authorArend van Spriel <arend@broadcom.com>
Thu, 12 Dec 2013 10:58:49 +0000 (11:58 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 18 Dec 2013 20:18:20 +0000 (15:18 -0500)
commitf4e78ccd115ea54dc2acd98496609f8e9dfb8967
tree51d3a0f0d0ab83a1ae3e3da3996e1b4d2b5d937e
parent33c974907220cf2ae2ab85fef4bef27eec9868ea
brcmfmac: add missing curly braces in brcmf_fws_txstatus_suppressed()

The 0-day testing from Fenguang Wu issued the following warning:

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master
head:   796f1d0d945fa2a131cc98d1adcb0b1e2f0d8335
commit: efee12ac0535a63a4e3c46b4611509043dab5344
    [33/59] brcmfmac: Update fwsignal to fix out of order tx.

>> drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1393:2-56:
    code aligned with following code on line 1394

vim +1393 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c

71309e44  1387  }
71309e44  1388
71309e44  1389  entry->generation = genbit;
71309e44  1390
4ef9caaa  1391  ret = brcmf_proto_hdrpull(fws->drvr, false, &ifidx, skb);
4ef9caaa  1392  if (ret == 0)
efee12ac @1393  brcmf_skb_htod_tag_set_field(skb, GENERATION, ..
efee12ac @1394  brcmf_skbcb(skb)->htod_seq = seq;
efee12ac  1395  if (brcmf_skb_htod_seq_get_field(skb, FROMFW)) {
efee12ac  1396  brcmf_skb_htod_seq_set_field(skb, ..
efee12ac  1397  brcmf_skb_htod_seq_set_field(skb, ..

This warning is valid and the if statement needs curly braces here.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c