]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f814fae) | patch
sh_eth: stop reading ECMR in sh_eth_dev_init()
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sun, 10 Jan 2016 21:28:14 +0000 (00:28 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Jan 2016 22:31:09 +0000 (17:31 -0500)
commitf4cc0d44026a5e2d18f473b99ab59c7c9b8cb857
tree77fe59349bc0de5be7377046e678eaa02f3ba0dbtree | snapshot
parentf814fae14edab25e36e71eed08fe7e257075a649commit | diff
sh_eth: stop reading ECMR in sh_eth_dev_init()

The code in sh_eth_dev_init()  twiddling the ECMR bits always looked a bit
strange to me:  if one intends to respect 'mdp->duplex', why save old value
of the ECMR.DM bit? As all the other bits are zeroed anyway, we don't really
need to read ECMR before writing to it.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/sh_eth.c diff | blob | history
Linux Kernel Source Tree.