]> git.baikalelectronics.ru Git - kernel.git/commit
cxgb4/l2t: Use struct_size() in kvzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 15 Jan 2019 21:44:52 +0000 (15:44 -0600)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Jan 2019 05:11:09 +0000 (21:11 -0800)
commitf4b8a009675fb033dccce95d54776a443fd498c1
treee8744c7c3c30c20b7fb74dbda69326ad81aab4b0
parent545655ea779a59c02091df2aa6e170f82c1e753c
cxgb4/l2t: Use struct_size() in kvzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/l2t.c