]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "hwmon: (pmbus) Add regulator supply into macro"
authorGuenter Roeck <linux@roeck-us.net>
Fri, 4 Nov 2022 23:37:30 +0000 (16:37 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 4 Nov 2022 23:47:01 +0000 (16:47 -0700)
commitf461bce07f2ff7215a69c92445525a2637c40317
treed0a6046e7c3e87c417b9f006a42242aac0dcb380
parent3d852d7bef81b5367064d52518764d7ec780d044
Revert "hwmon: (pmbus) Add regulator supply into macro"

This reverts commit b47f0481a7e0e50d75db678d7099b6926c134032.

Zev Weiss reports that the reverted patch may cause a regulator
undercount. Here is his report:

... having regulator-dummy set as a supply on my PMBus regulators
(instead of having them as their own top-level regulators without
an upstream supply) leads to enable-count underflow errors when
disabling them:

    # echo 0 > /sys/bus/platform/devices/efuse01/state
    [  906.094477] regulator-dummy: Underflow of regulator enable count
    [  906.100563] Failed to disable vout: -EINVAL
    [  136.992676] reg-userspace-consumer efuse01: Failed to configure state: -22

Zev reports that reverting the patch fixes the problem. So let's do that
for now.

Fixes: b47f0481a7e0 ("hwmon: (pmbus) Add regulator supply into macro")
Cc: Marcello Sylvester Bauer <sylv@sylv.io>
Reported-by: Zev Weiss <zev@bewilderbeest.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/pmbus.h