]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "brcmfmac: add a check for the status of usb_register"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:57:35 +0000 (13:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 16:58:41 +0000 (18:58 +0200)
commitf453dbff993e3bd6397a2b5143237c70591fd44d
tree5b9959b2b12676a21116e13d8b72f5ec14822b25
parent01a154a96d1e5f7fe0b2c2d85cab008d47822a10
Revert "brcmfmac: add a check for the status of usb_register"

This reverts commit a981f6f70ea3abffe27803270a36d99e2e35e051.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original commit here did nothing to actually help if usb_register()
failed, so it gives a "false sense of security" when there is none.  The
correct solution is to correctly unwind from this error.

Cc: Kangjie Lu <kjlu@umn.edu>
Cc: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-69-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c