]> git.baikalelectronics.ru Git - kernel.git/commit
apei/ghes: Do not delay GHES polling
authorBhaskar Upadhaya <bupadhaya@marvell.com>
Wed, 8 Jan 2020 17:17:38 +0000 (09:17 -0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 13 Jan 2020 10:49:55 +0000 (11:49 +0100)
commitf41f5b4f84b700f61451254885f1d0a9ffdf85a5
treeb994fd804abd653de8cdf2941cad70bfad8a3e42
parentf1900be5a74dbaa08f19e3aaa9fd854e846d520c
apei/ghes: Do not delay GHES polling

Currently, the ghes_poll_func() timer callback is registered with the
TIMER_DEFERRABLE flag. Thus, it is run when the CPU eventually wakes
up together with a subsequent non-deferrable timer and not at the precisely
configured polling interval.

For polling mode, the polling interval configured by firmware should not
be exceeded according to the ACPI spec 6.3, Table 18-394. The definition
of the polling interval is:

"Indicates the poll interval in milliseconds OSPM should use to
 periodically check the error source for the presence of an error
 condition."

If this interval is extended due to the timer callback deferring, error
records can get lost. Which we are observing on our ThunderX2 platforms.

Therefore, remove the TIMER_DEFERRABLE flag so that the timer callback
executes at the precise interval.

Signed-off-by: Bhaskar Upadhaya <bupadhaya@marvell.com>
[ bp: Subject & changelog ]
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/apei/ghes.c