]> git.baikalelectronics.ru Git - kernel.git/commit
net: tulip: Adjust indentation in {dmfe, uli526x}_init_module
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 9 Dec 2019 21:16:23 +0000 (14:16 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Dec 2019 04:28:22 +0000 (20:28 -0800)
commitf3c84cd9e88e7905f1c76e83150e552098b785aa
tree4871b2d8e63f49bce19ab70336c16395b07d8762
parent2be4931411afcbb22e4ead4b2aaa20b71f16d113
net: tulip: Adjust indentation in {dmfe, uli526x}_init_module

Clang warns:

../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        switch (mode) {
        ^
../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous
statement is here
        if (cr6set)
        ^
1 warning generated.

../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        switch(mode) {
        ^
../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous
statement is here
        if (cr6set)
        ^
1 warning generated.

This warning occurs because there is a space before the tab on these
lines. Remove them so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

While we are here, adjust the default block in dmfe_init_module to have
a proper break between the label and assignment and add a space between
the switch and opening parentheses to avoid a checkpatch warning.

Fixes: bbdd8957099c ("[PATCH] initialisation cleanup for ULI526x-net-driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/795
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/dec/tulip/dmfe.c
drivers/net/ethernet/dec/tulip/uli526x.c