]> git.baikalelectronics.ru Git - kernel.git/commit
switchdev: fix BUG when port driver doesn't support set attr op
authorScott Feldman <sfeldma@gmail.com>
Thu, 11 Jun 2015 15:19:01 +0000 (08:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Jun 2015 23:27:09 +0000 (16:27 -0700)
commitf3adb534187e438c208ce5856e25b8b345e600b9
tree9ebdc1f6899baf7496a8907323a6ae9e55cc390f
parent83ea3abc71ef2500bc024a65777bcd44d7e0a431
switchdev: fix BUG when port driver doesn't support set attr op

Fix a BUG_ON() where CONFIG_NET_SWITCHDEV is set but the driver for a
bridged port does not support switchdev_port_attr_set op.  Don't BUG_ON()
if -EOPNOTSUPP is returned.

Also change BUG_ON() to netdev_err since this is a normal error path and
does not warrant the use of BUG_ON(), which is reserved for unrecoverable
errs.

Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Reported-by: Brenden Blanco <bblanco@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/switchdev/switchdev.c