]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: nf_tables: fix use-after-free when deleting compat expressions
authorFlorian Westphal <fw@strlen.de>
Mon, 12 Nov 2018 21:43:45 +0000 (22:43 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 13 Nov 2018 08:57:33 +0000 (09:57 +0100)
commitf36c44e3f15560102c2f9247daf50d78e876bc23
treec1bd28510eb2dbacce9076ca3f4b4eb6c173a515
parentacecff6285b64bab8662cfcb5d54562d3574bd25
netfilter: nf_tables: fix use-after-free when deleting compat expressions

nft_compat ops do not have static storage duration, unlike all other
expressions.

When nf_tables_expr_destroy() returns, expr->ops might have been
free'd already, so we need to store next address before calling
expression destructor.

For same reason, we can't deref match pointer after nft_xt_put().

This can be easily reproduced by adding msleep() before
nft_match_destroy() returns.

Fixes: ff4564a5c9cc ("netfilter: nf_tables: add compatibility layer for x_tables")
Reported-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c
net/netfilter/nft_compat.c