]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: rawnand: xway: Move the ECC initialization to ->attach_chip()
authorMiquel Raynal <miquel.raynal@bootlin.com>
Fri, 13 Nov 2020 12:34:07 +0000 (13:34 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 19 Nov 2020 20:36:28 +0000 (21:36 +0100)
commitf36b147c692dbba0a275c22cd84c04837706acc9
treefcebfe3f22de9e0333b17b8665ee9f2a1ddd2fe0
parent2a35246d4403e3c2a41f5cd49539ed05a489e8a1
mtd: rawnand: xway: Move the ECC initialization to ->attach_chip()

The probe function is only supposed to initialize the controller
hardware but not the ECC engine. Indeed, we don't know anything about
the NAND chip(s) at this stage. Let's move the logic initializing the
ECC engine, even pretty simple, to the ->attach_chip() hook which gets
called during nand_scan() routine, after the NAND chip discovery. As
the previously mentioned logic is supposed to parse the DT for us, it
is likely that the chip->ecc.* entries be overwritten. So let's avoid
this by moving these lines to ->attach_chip(), a NAND controller
hook.

Fixes: 86503c2fe61f ("mtd: rawnand: Use the ECC framework user input parsing bits")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20201113123424.32233-3-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/xway_nand.c