]> git.baikalelectronics.ru Git - kernel.git/commit
xhci: avoid race between disable slot command and host runtime suspend
authorMathias Nyman <mathias.nyman@linux.intel.com>
Fri, 10 Dec 2021 14:17:35 +0000 (16:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Dec 2021 09:57:20 +0000 (10:57 +0100)
commitf32d56eef4f861199247d5a78e459b15c35dcad3
tree06f86768a6f0cbd85d8cd9b46f4229407410d49f
parenta22d219ad4233bcc223c6587c0e8fc5efe7138f0
xhci: avoid race between disable slot command and host runtime suspend

commit 42bf399b55bb6cd390bb662e4134dbb2aa926a3f upstream.

Make xhci_disable_slot() synchronous, thus ensuring it, and
xhci_free_dev() calling it return after xHC controller completes
the disable slot command.

Otherwise the roothub and xHC host may runtime suspend, and clear the
command ring while the disable slot command is being processed.

This causes a command completion mismatch as the completion event can't
be mapped to the correct command.
Command ring gets out of sync and commands time out.
Driver finally assumes host is unresponsive and bails out.

usb 2-4: USB disconnect, device number 10
xhci_hcd 0000:00:0d.0: ERROR mismatched command completion event
...
xhci_hcd 0000:00:0d.0: xHCI host controller not responding, assume dead
xhci_hcd 0000:00:0d.0: HC died; cleaning up

Cc: <stable@vger.kernel.org>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20211210141735.1384209-3-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-hub.c
drivers/usb/host/xhci-ring.c
drivers/usb/host/xhci.c