]> git.baikalelectronics.ru Git - kernel.git/commit
device property: fix of node refcount leak in fwnode_graph_get_next_endpoint()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 23 Nov 2022 02:25:42 +0000 (10:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:34:26 +0000 (08:34 +0100)
commitf31ecb6da2441f613450b445bf3b36a6fe63bf9a
treea8bd7333fcf8ac2437ae2be211b6f6eefc666f33
parentf379576a40f401314835941fa727a9a373895473
device property: fix of node refcount leak in fwnode_graph_get_next_endpoint()

[ Upstream commit 94a860f0ca40f350d10c19884d0c202beb8bfa4e ]

The 'parent' returned by fwnode_graph_get_port_parent()
with refcount incremented when 'prev' is not NULL, it
needs be put when finish using it.

Because the parent is const, introduce a new variable to
store the returned fwnode, then put it before returning
from fwnode_graph_get_next_endpoint().

Fixes: 09587e998f9e ("device property: Check fwnode->secondary in fwnode_graph_get_next_endpoint()")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-and-tested-by: Daniel Scally <djrscally@gmail.com>
Link: https://lore.kernel.org/r/20221123022542.2999510-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/base/property.c