]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/execlists: Relax CSB force-mmio for VT-d
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 11 May 2018 12:11:47 +0000 (13:11 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 14 May 2018 08:40:58 +0000 (09:40 +0100)
commitf29b825c2ea585c3763b5b60bc018467edd5936c
treebcd74f9e510a8a5b982bf53f4816d982e8bbbecd
parent3c3ce2f5e5efa955c03def4e539a925888ef178a
drm/i915/execlists: Relax CSB force-mmio for VT-d

The original switch to use CSB from the HWSP was plagued by the effect
of read ordering on VT-d; we would read the WRITE pointer from the HWSP
before it had completed writing the CSB contents. The mystery comes down
to the lack of rmb() for correct ordering with respect to the writes
from HW, and with that resolved we can remove the VT-d special casing.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: MichaƂ Winiarski <michal.winiarski@intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180511121147.31915-3-chris@chris-wilson.co.uk
Tested-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
drivers/gpu/drm/i915/intel_engine_cs.c