]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: dwc: Stop link on host_init errors and de-initialization
authorBaikal Electronics <support@baikalelectronics.ru>
Fri, 24 Jun 2022 14:34:11 +0000 (17:34 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:47 +0000 (14:23 +0200)
commitf22dfcf0117b8d1b0e54d62551b51e892773f352
tree7113affa562089cc835e079994f95982ec261185
parentfcbca57cacb586c7b2a26c9813bb16a496c7c67e
PCI: dwc: Stop link on host_init errors and de-initialization

[ Upstream commit f848c19f598a9b8dc9a717579f1a71fe0fca4a10 ]

It's logically correct to undo everything that was done when an error is
discovered or in the corresponding cleanup counterpart. Otherwise the host
controller will be left in an undetermined state. Since the link is set up
in the host_init method, deactivate it there in the cleanup-on-error block
and stop the link in the antagonistic routine - dw_pcie_host_deinit(). Link
deactivation is platform-specific and should be implemented in
dw_pcie_ops.stop_link().

Fixes: b337f432d9f8 ("PCI: dwc: Move link handling into common code")
Link: https://lore.kernel.org/r/20220624143428.8334-2-Sergey.Semin@baikalelectronics.ru
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/controller/dwc/pcie-designware-host.c