]> git.baikalelectronics.ru Git - kernel.git/commit
net/dim: Fix fixpoint divide exception in net_dim_stats_compare
authorTalat Batheesh <talatb@mellanox.com>
Wed, 17 Jan 2018 21:13:16 +0000 (23:13 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Jan 2018 19:53:32 +0000 (14:53 -0500)
commitf201031b65a519f0ab24e9dc29886630b54da276
tree894a3fccfd3ca4555476dcbac1ba2e99485f4049
parentcb1fd7578ce8076744e285f2c2793bda965bed5b
net/dim: Fix fixpoint divide exception in net_dim_stats_compare

Helmut reported a bug about devision by zero while
running traffic and doing physical cable pull test.

When the cable unplugged the ppms become zero, so when
dividing the current ppms by the previous ppms in the
next dim iteration there is devision by zero.

This patch prevent this division for both ppms and epms.

Fixes: 012793b1db1e ("net/mlx5e: Added BW check for DIM decision mechanism")
Fixes: d28cee41da7e ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux")
Reported-by: Helmut Grauer <helmut.grauer@de.ibm.com>
Signed-off-by: Talat Batheesh <talatb@mellanox.com>
Signed-off-by: Tal Gilboa <talgi@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/net_dim.h