]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "bridge: do not add port to router list when receives query with source 0...
authorHangbin Liu <liuhangbin@gmail.com>
Fri, 22 Feb 2019 13:22:32 +0000 (21:22 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 24 Feb 2019 02:36:06 +0000 (18:36 -0800)
commitf1f0c6d0bf5f1b951683ad4c0ee78df0e9546bb0
tree87a2ee311e531bdce3e38e773c4adc2a85a3ab01
parent272eb3083dc70c45450bb5d8aa34ec2e522cae12
Revert "bridge: do not add port to router list when receives query with source 0.0.0.0"

This reverts commit e86a3d48bc7f ("bridge: do not add port to router list
when receives query with source 0.0.0.0") and commit 7ca814f685f2 ("net:
bridge: remove ipv6 zero address check in mcast queries")

The reason is RFC 4541 is not a standard but suggestive. Currently we
will elect 0.0.0.0 as Querier if there is no ip address configured on
bridge. If we do not add the port which recives query with source
0.0.0.0 to router list, the IGMP reports will not be about to forward
to Querier, IGMP data will also not be able to forward to dest.

As Nikolay suggested, revert this change first and add a boolopt api
to disable none-zero election in future if needed.

Reported-by: Linus Lüssing <linus.luessing@c0d3.blue>
Reported-by: Sebastian Gottschall <s.gottschall@newmedia-net.de>
Fixes: e86a3d48bc7f ("bridge: do not add port to router list when receives query with source 0.0.0.0")
Fixes: 7ca814f685f2 ("net: bridge: remove ipv6 zero address check in mcast queries")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_multicast.c