]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: SOF: ipc3-topology: Prevent double freeing of ipc_control_data via load_bytes
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Tue, 12 Jul 2022 13:01:03 +0000 (16:01 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 12 Jul 2022 16:39:25 +0000 (17:39 +0100)
commitf073fef740aa3bad4a4e72e341e5f0a1e0a0ebc4
tree5b142ab3ecb98158763d2d519a5b361175a3a6e1
parent57691e32308e0360bfa8793589e8a9b6ce60f2c4
ASoC: SOF: ipc3-topology: Prevent double freeing of ipc_control_data via load_bytes

We have sanity checks for byte controls and if any of the fail the locally
allocated scontrol->ipc_control_data is freed up, but not set to NULL.

On a rollback path of the error the higher level code will also try to free
the scontrol->ipc_control_data which will eventually going to lead to
memory corruption as double freeing memory is not a good thing.

Fixes: 806f4f0b3d81 ("ASoC: SOF: topology: Make control parsing IPC agnostic")
Reported-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220712130103.31514-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc3-topology.c