]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: b53: Keep CPU port as tagged in all VLANs
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 5 Oct 2018 03:24:13 +0000 (20:24 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Oct 2018 04:52:49 +0000 (21:52 -0700)
commitefc58488c9294cd289690d133f24fa30b1eea222
treec24ede5ccead8729da4400bc81a6147fefcfcc77
parent1dc6def856e97b31dababd97e194229d72869b1c
net: dsa: b53: Keep CPU port as tagged in all VLANs

Commit a49062fedac3 ("net: dsa: b53: Stop using dev->cpu_port
incorrectly") was a bit too trigger happy in removing the CPU port from
the VLAN membership because we rely on DSA to program the CPU port VLAN,
which it does, except it does not bother itself with tagged/untagged and
just usese untagged.

Having the CPU port "follow" the user ports tagged/untagged is not great
and does not allow for properly differentiating, so keep the CPU port
tagged in all VLANs.

Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
Fixes: a49062fedac3 ("net: dsa: b53: Stop using dev->cpu_port incorrectly")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/b53/b53_common.c