]> git.baikalelectronics.ru Git - kernel.git/commit
fixup! wil6210: fix usage of print_hex_dump_debug
authorVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Sun, 14 Sep 2014 08:14:10 +0000 (11:14 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 15 Sep 2014 19:00:53 +0000 (15:00 -0400)
commitef8e536d181d5e5b900e0d2ca495d9f56246696f
tree508d0a9be50a7c2fe959c1de1ad60faaff3af81e
parentcd75b00ef3ebd4acd191fc6cfdf25a8d03963672
fixup! wil6210: fix usage of print_hex_dump_debug

Use empty inline functions instead of empty #define. Fix for "unused variable"
as reported below:

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master
head:   add9101ebb1570698de633670e4713f69a249193
commit: d6fc63411fc4251bb7b70d8aaec5eefef9b3998e [45/62] wil6210: fix usage of print_hex_dump_debug
config: i386-allyesconfig
reproduce:
  git checkout d6fc63411fc4251bb7b70d8aaec5eefef9b3998e
  make ARCH=i386  allyesconfig
  make ARCH=i386

All warnings:

   drivers/net/wireless/ath/wil6210/wmi.c: In function 'wmi_evt_rx_mgmt':

>> drivers/net/wireless/ath/wil6210/wmi.c:341:10: warning: unused variable 'ie_len' [-Wunused-variable]
      size_t ie_len = d_len - offsetof(struct ieee80211_mgmt,
             ^

>> drivers/net/wireless/ath/wil6210/wmi.c:340:13: warning: unused variable 'ie_buf' [-Wunused-variable]
      const u8 *ie_buf = rx_mgmt_frame->u.beacon.variable;
                ^

vim +/ie_len +341 drivers/net/wireless/ath/wil6210/wmi.c

91d92cac Vladimir Kondratiev 2012-12-20  334
91d92cac Vladimir Kondratiev 2012-12-20  335    if (ieee80211_is_beacon(fc) || ieee80211_is_probe_resp(fc)) {
91d92cac Vladimir Kondratiev 2012-12-20  336            struct cfg80211_bss *bss;
4c62ddb8 Vladimir Kondratiev 2014-06-16  337            u64 tsf = le64_to_cpu(rx_mgmt_frame->u.beacon.timestamp);
4c62ddb8 Vladimir Kondratiev 2014-06-16  338            u16 cap = le16_to_cpu(rx_mgmt_frame->u.beacon.capab_info);
4c62ddb8 Vladimir Kondratiev 2014-06-16  339            u16 bi = le16_to_cpu(rx_mgmt_frame->u.beacon.beacon_int);
4c62ddb8 Vladimir Kondratiev 2014-06-16  340            const u8 *ie_buf = rx_mgmt_frame->u.beacon.variable;
4c62ddb8 Vladimir Kondratiev 2014-06-16  341            size_t ie_len = d_len - offsetof(struct ieee80211_mgmt,
4c62ddb8 Vladimir Kondratiev 2014-06-16  342                                             u.beacon.variable);
4c62ddb8 Vladimir Kondratiev 2014-06-16  343            wil_dbg_wmi(wil, "Capability info : 0x%04x\n", cap);
4c62ddb8 Vladimir Kondratiev 2014-06-16  344            wil_dbg_wmi(wil, "TSF : 0x%016llx\n", tsf);

:::::: The code at line 341 was first introduced by commit
:::::: 4c62ddb884f0f7fd4526b3404d7e0b0f37c9203b wil6210: print more info about BSS found

Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/wil6210/wil6210.h