]> git.baikalelectronics.ru Git - kernel.git/commit
phy: qualcomm: call clk_disable_unprepare in the error handling
authorDongliang Mu <mudongliangabcd@gmail.com>
Wed, 14 Sep 2022 05:13:33 +0000 (13:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:22:40 +0000 (13:22 +0200)
commitee2c807088719c033603233f14cff2debf6947c9
treeb0a2a3328e68e8f4c369a4a080eed45add3fe028
parent9b8a7ce0fa4e5f4248ca2b11984677d663c4a83d
phy: qualcomm: call clk_disable_unprepare in the error handling

[ Upstream commit 77bc762b2afdbf46fccfe810f6f3404749d785b2 ]

Smatch reports the following error:

drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
warn: 'uphy->cal_clk' from clk_prepare_enable() not released on lines:
58.
drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
warn: 'uphy->cal_sleep_clk' from clk_prepare_enable() not released on
lines: 58.
drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
warn: 'uphy->phy_clk' from clk_prepare_enable() not released on lines:
58.

Fix this by calling proper clk_disable_unprepare calls.

Fixes: b63d59fddb73 ("phy: Group vendor specific phy drivers")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20220914051334.69282-1-dzm91@hust.edu.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/phy/qualcomm/phy-qcom-usb-hsic.c