]> git.baikalelectronics.ru Git - kernel.git/commit
pas16: don't call free_dma()
authorArnd Bergmann <arnd@arndb.de>
Thu, 5 Jun 2014 21:29:47 +0000 (23:29 +0200)
committerChristoph Hellwig <hch@lst.de>
Fri, 25 Jul 2014 21:16:55 +0000 (17:16 -0400)
commitee17400c1fa634d4bfc8761d1e2a68c5a8866774
treebe476bba987f023da75b80eea2a3c99639847d86
parent307e22c4c8843d28c7a0f2f5811874577f4e2b0d
pas16: don't call free_dma()

The pas16 scsi driver does not use DMA, and the call to free_dma()
in its exit function seems to have been copied incorrectly from
another driver but never caused trouble.

One case where it gets in the way is randconfig builds on ARM,
which depending on the configuration does not provide a free_dma()
function, causing this build error:

drivers/scsi/pas16.c: In function 'pas16_release':
drivers/scsi/pas16.c:611:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration]
   free_dma(shost->dma_channel);

Removing the incorrect function calls should be the obvious
fix for this, with no downsides.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/pas16.c