]> git.baikalelectronics.ru Git - kernel.git/commit
video: fbdev: kyro: Error out if 'lineclock' equals zero
authorZheyu Ma <zheyuma97@gmail.com>
Mon, 4 Apr 2022 08:47:19 +0000 (16:47 +0800)
committerHelge Deller <deller@gmx.de>
Mon, 11 Apr 2022 06:23:49 +0000 (08:23 +0200)
commited2c3ba8568c3ac3df0b223d9ae87ffe6c14c279
tree1ed5a45d00f73105df698d6a7a5bba9abef9ee18
parent26f4dee8865333eb433f9c1f78b80935beaa3cba
video: fbdev: kyro: Error out if 'lineclock' equals zero

The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of 'lineclock',
it may cause divide error.

Fix this by checking whether 'lineclock' is zero.

The following log reveals it:
 divide error: 0000 [#1] PREEMPT SMP KASAN PTI
 RIP: 0010:kyrofb_set_par+0x30d/0xd80
 Call Trace:
  <TASK>
  fb_set_var+0x604/0xeb0
  do_fb_ioctl+0x234/0x670
  fb_ioctl+0xdd/0x130
  do_syscall_64+0x3b/0x90

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/kyro/fbdev.c