]> git.baikalelectronics.ru Git - kernel.git/commit
xhci: Fix commad ring abort, write all 64 bits to CRCR register.
authorMathias Nyman <mathias.nyman@linux.intel.com>
Fri, 26 Nov 2021 12:23:40 +0000 (14:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Dec 2021 12:56:33 +0000 (13:56 +0100)
commited2c19ed86a6b074abc3241ecdb0fa79e795d78b
treebadd026dcef7b588e8c919c157aa9166f542e735
parentb1a885c0f40e89a4fd0f041736592b4ab46bfe8a
xhci: Fix commad ring abort, write all 64 bits to CRCR register.

Turns out some xHC controllers require all 64 bits in the CRCR register
to be written to execute a command abort.

The lower 32 bits containing the command abort bit is written first.
In case the command ring stops before we write the upper 32 bits then
hardware may use these upper bits to set the commnd ring dequeue pointer.

Solve this by making sure the upper 32 bits contain a valid command
ring dequeue pointer.

The original patch that only wrote the first 32 to stop the ring went
to stable, so this fix should go there as well.

Fixes: 26c74278ede8 ("xhci: Fix command ring pointer corruption while aborting a command")
Cc: stable@vger.kernel.org
Tested-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20211126122340.1193239-2-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c