]> git.baikalelectronics.ru Git - kernel.git/commit
mlxsw: Fix firmware flashing
authorIdo Schimmel <idosch@nvidia.com>
Tue, 17 Nov 2020 17:33:51 +0000 (19:33 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Nov 2020 19:07:00 +0000 (11:07 -0800)
commitec5c91055248f1195ab4281e47ffdfb4e4609078
treeaa1e20e2e2d9d50193e55180101c89a7669e49ea
parente14ecf5c8371f5e3c2a2e82166d1e38a2fd854e1
mlxsw: Fix firmware flashing

The commit cited below moved firmware flashing functionality from
mlxsw_spectrum to mlxsw_core, but did not adjust the Kconfig
dependencies. This makes it possible to have mlxsw_core as built-in and
mlxfw as a module. The mlxfw code is therefore not reachable from
mlxsw_core and firmware flashing fails:

# devlink dev flash pci/0000:01:00.0 file mellanox/mlxsw_spectrum-13.2008.1310.mfa2
devlink answers: Operation not supported

Fix by having mlxsw_core select mlxfw.

Fixes: d7c0dfdfc39c ("mlxsw: Move fw flashing code into core.c")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reported-by: Vadim Pasternak <vadimp@nvidia.com>
Tested-by: Vadim Pasternak <vadimp@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/Kconfig