]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: mxcmmc: fix return value check of mmc_add_host()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 1 Nov 2022 06:30:17 +0000 (14:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:23 +0000 (13:32 +0100)
commitebb72c1a2139bae793685886209ff48dd7498354
tree0f816019327b9d613c5308b3c08c69f95dd7e0a2
parentac60a88568c99217b48a93db4478f4a82cd38e3b
mmc: mxcmmc: fix return value check of mmc_add_host()

[ Upstream commit d98b50804862bbe57fa638aa35b7fe9140ae67d0 ]

mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and goto error path which will call
mmc_free_host().

Fixes: a65a4972f2f5 ("mmc: Add a MX2/MX3 specific SDHC driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-4-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/mxcmmc.c