]> git.baikalelectronics.ru Git - kernel.git/commit
iommu/amd: Enable swiotlb in all cases
authorMario Limonciello <mario.limonciello@amd.com>
Mon, 4 Apr 2022 20:47:22 +0000 (15:47 -0500)
committerJoerg Roedel <jroedel@suse.de>
Thu, 28 Apr 2022 08:26:49 +0000 (10:26 +0200)
commitebaf29125e5f729e26fb87c60008f1257857c484
treefeb6830cf26abee59c6e3a2ed4a4e34fde71ee91
parent7c464de09a7344a2cfcff7733684bbcf4ce79cc5
iommu/amd: Enable swiotlb in all cases

Previously the AMD IOMMU would only enable SWIOTLB in certain
circumstances:
 * IOMMU in passthrough mode
 * SME enabled

This logic however doesn't work when an untrusted device is plugged in
that doesn't do page aligned DMA transactions.  The expectation is
that a bounce buffer is used for those transactions.

This fails like this:

swiotlb buffer is full (sz: 4096 bytes), total 0 (slots), used 0 (slots)

That happens because the bounce buffers have been allocated, followed by
freed during startup but the bounce buffering code expects that all IOMMUs
have left it enabled.

Remove the criteria to set up bounce buffers on AMD systems to ensure
they're always available for supporting untrusted devices.

Fixes: 623df59241e9 ("iommu: Allow the dma-iommu api to use bounce buffers")
Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220404204723.9767-2-mario.limonciello@amd.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd/iommu.c