]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (mcp3021) Fix broken output scaling
authorStevens, Nick <Nick.Stevens@digi.com>
Wed, 1 Jul 2015 16:07:41 +0000 (16:07 +0000)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 1 Jul 2015 20:56:27 +0000 (13:56 -0700)
commitea9fe6284087b8d08c72618051aeb1bd3213d69b
tree2372f376a79f0b97722a687de31a93af33ca3937
parentdd319c11f4809d92cbec34361362ae713d1267bb
hwmon: (mcp3021) Fix broken output scaling

The mcp3021 scaling code is dividing the VDD (full-scale) value in
millivolts by the A2D resolution to obtain the scaling factor. When VDD
is 3300mV (the standard value) and the resolution is 12-bit (4096
divisions), the result is a scale factor of 3300/4096, which is always
one.  Effectively, the raw A2D reading is always being returned because
no scaling is applied.

This patch fixes the issue and simplifies the register-to-volts
calculation, removing the unneeded "output_scale" struct member.

Signed-off-by: Nick Stevens <Nick.Stevens@digi.com>
Cc: stable@vger.kernel.org # v3.10+
[Guenter Roeck: Dropped unnecessary value check]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/mcp3021.c