]> git.baikalelectronics.ru Git - kernel.git/commit
KEYS: sanitize key structs before freeing
authorEric Biggers <ebiggers@google.com>
Thu, 8 Jun 2017 13:49:26 +0000 (14:49 +0100)
committerJames Morris <james.l.morris@oracle.com>
Fri, 9 Jun 2017 03:29:48 +0000 (13:29 +1000)
commitea9624bd30708661fb39e5ddea6b3cc4a872a3c0
treee946b82852f2e72c559a1acaa458e7d6e0173acc
parentc0a1473afb9899fcee47e646363e8800d4230df1
KEYS: sanitize key structs before freeing

While a 'struct key' itself normally does not contain sensitive
information, Documentation/security/keys.txt actually encourages this:

     "Having a payload is not required; and the payload can, in fact,
     just be a value stored in the struct key itself."

In case someone has taken this advice, or will take this advice in the
future, zero the key structure before freeing it.  We might as well, and
as a bonus this could make it a bit more difficult for an adversary to
determine which keys have recently been in use.

This is safe because the key_jar cache does not use a constructor.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
include/linux/key.h
security/keys/gc.c