]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: ufs: ufshpb: Fix a NULL check on list iterator
authorXiaomeng Tong <xiam0nd.tong@gmail.com>
Sun, 20 Mar 2022 15:07:33 +0000 (23:07 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 7 Apr 2022 02:40:41 +0000 (22:40 -0400)
commitea6f2578c844b51d98ea0ea5fa9dede32f123b3e
tree89932197c4ad0589f747fb89c868de37b1b1d684
parent869e634eddacb3fbc5ab983eaa46eb8e284604f1
scsi: ufs: ufshpb: Fix a NULL check on list iterator

The list iterator is always non-NULL so the check 'if (!rgn)' is always
false and the dev_err() is never called. Move the check outside the loop
and determine if 'victim_rgn' is NULL, to fix this bug.

Link: https://lore.kernel.org/r/20220320150733.21824-1-xiam0nd.tong@gmail.com
Fixes: ca2f60808241 ("scsi: ufs: ufshpb: L2P map management for HPB read")
Reviewed-by: Daejun Park <daejun7.park@samsung.com>
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshpb.c