]> git.baikalelectronics.ru Git - kernel.git/commit
can: isotp: fix msg_namelen values depending on CAN_REQUIRED_SIZE
authorOliver Hartkopp <socketcan@hartkopp.net>
Thu, 25 Mar 2021 12:58:49 +0000 (13:58 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 29 Mar 2021 07:51:43 +0000 (09:51 +0200)
commite9a5f9909951bd6be9265a098bd208ed74dbb632
tree6887546071b57eec92b9a60b2a49f11c75bf6c0f
parent13d4197c489fd891b7b0bbfcdb77a9e6e17844c1
can: isotp: fix msg_namelen values depending on CAN_REQUIRED_SIZE

Since commit 5629cb1918e0 ("can: extend sockaddr_can to include j1939
members") the sockaddr_can has been extended in size and a new
CAN_REQUIRED_SIZE macro has been introduced to calculate the protocol
specific needed size.

The ABI for the msg_name and msg_namelen has not been adapted to the
new CAN_REQUIRED_SIZE macro for the other CAN protocols which leads to
a problem when an existing binary reads the (increased) struct
sockaddr_can in msg_name.

Fixes: 28da5a05c8c3 ("can: add ISO 15765-2:2016 transport protocol")
Reported-by: Richard Weinberger <richard@nod.at>
Acked-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Link: https://lore.kernel.org/linux-can/1135648123.112255.1616613706554.JavaMail.zimbra@nod.at/T/#t
Link: https://lore.kernel.org/r/20210325125850.1620-2-socketcan@hartkopp.net
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/isotp.c