]> git.baikalelectronics.ru Git - kernel.git/commit
Bluetooth: Fix not cleanup led when bt_init fails
authorChen Zhongjin <chenzhongjin@huawei.com>
Tue, 29 Nov 2022 09:25:56 +0000 (17:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Dec 2022 10:30:45 +0000 (11:30 +0100)
commite993e280706072042ec447b08cdf1efcbc7b5b15
treeb5a1c47920346962c34506cc717f2dc4333e45e5
parent40e9d89220d0f239cb3a781932d06f95a2af5cc9
Bluetooth: Fix not cleanup led when bt_init fails

[ Upstream commit f168d2dfb87e3dc59756ad33e4852b04650ce208 ]

bt_init() calls bt_leds_init() to register led, but if it fails later,
bt_leds_cleanup() is not called to unregister it.

This can cause panic if the argument "bluetooth-power" in text is freed
and then another led_trigger_register() tries to access it:

BUG: unable to handle page fault for address: ffffffffc06d3bc0
RIP: 0010:strcmp+0xc/0x30
  Call Trace:
    <TASK>
    led_trigger_register+0x10d/0x4f0
    led_trigger_register_simple+0x7d/0x100
    bt_init+0x39/0xf7 [bluetooth]
    do_one_initcall+0xd0/0x4e0

Fixes: ef490f612414 ("Bluetooth: Add combined LED trigger for controller power")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/bluetooth/af_bluetooth.c