]> git.baikalelectronics.ru Git - kernel.git/commit
usb: ulpi: defer ulpi_register on ulpi_read_id timeout
authorFerry Toth <ftoth@exalondelft.nl>
Mon, 5 Dec 2022 20:15:26 +0000 (21:15 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:42:02 +0000 (11:42 +0100)
commite969aabe7d085822ca79b936f53af867a515eeba
tree237df5a6cfaa395e2a2b5797783a769a0e4d75fa
parent4526eaa8dacc5fb809047c9bc73339ab698c9ef0
usb: ulpi: defer ulpi_register on ulpi_read_id timeout

[ Upstream commit 93853e44097e3396df9c292318463834e4dbf019 ]

Since commit 9df44fa57d5f ("usb: dwc3: Don't switch OTG -> peripheral
if extcon is present") Dual Role support on Intel Merrifield platform
broke due to rearranging the call to dwc3_get_extcon().

It appears to be caused by ulpi_read_id() on the first test write failing
with -ETIMEDOUT. Currently ulpi_read_id() expects to discover the phy via
DT when the test write fails and returns 0 in that case, even if DT does not
provide the phy. As a result usb probe completes without phy.

Make ulpi_read_id() return -ETIMEDOUT to its user if the first test write
fails. The user should then handle it appropriately. A follow up patch
will make dwc3_core_init() set -EPROBE_DEFER in this case and bail out.

Fixes: 69b21a933df9 ("usb: ulpi: Support device discovery via DT")
Cc: stable@vger.kernel.org
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
Link: https://lore.kernel.org/r/20221205201527.13525-2-ftoth@exalondelft.nl
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/common/ulpi.c