]> git.baikalelectronics.ru Git - kernel.git/commit
media: dvb-frontends/drxk_hard.c: fix uninitialized variable warning
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 8 Oct 2020 11:59:13 +0000 (13:59 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 8 Oct 2020 12:15:14 +0000 (14:15 +0200)
commite8f0c6e893568f4e4c299e3a341c4183651616a9
tree4bdec622216e0a3dd9c064d6c120b529a73552f0
parenteaa59adbc643f99d9f08acf618f5920631b88645
media: dvb-frontends/drxk_hard.c: fix uninitialized variable warning

drxk_hard.c: In function 'hi_command.constprop':
drxk_hard.c:1016:5: warning: 'wait_cmd' may be used uninitialized in this function [-Wmaybe-uninitialized]
 1015 |   } while ((status < 0) && (retry_count < DRXK_MAX_RETRIES)
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1016 |     && (wait_cmd != 0));
      |     ^~~~~~~~~~~~~~~~~~

The underlying cause is that the while condition is wrong. It should be:

(status < 0 || wait_cmd) && (retry_count < DRXK_MAX_RETRIES)

'wait_cmd' is only valid if '!(status < 0)'.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-frontends/drxk_hard.c