]> git.baikalelectronics.ru Git - kernel.git/commit
drm: rcar-du: add missing of_node_put
authorJulia Lawall <julia.lawall@lip6.fr>
Mon, 14 Jan 2019 16:44:56 +0000 (17:44 +0100)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Fri, 8 Feb 2019 00:25:55 +0000 (02:25 +0200)
commite8c2cea1c947c4b39918677cab928bda5ae11a10
treea92be4505ffc2db6c5fc2e34cd213061a9419302
parent02c5dec73c0409f3e5a60ccffb905fb61c549521
drm: rcar-du: add missing of_node_put

Add an of_node_put when the result of of_graph_get_remote_port_parent is
not available.

Add a second of_node_put if no encoder is selected (encoder remains NULL).

The semantic match that finds the first problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@r exists@
local idexpression e;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
    when != true e == NULL
    when != of_node_put(e)
    when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
drivers/gpu/drm/rcar-du/rcar_du_kms.c