]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: qla2xxx: Fix use-after-free issues in qla2xxx_qpair_sp_free_dma()
authorBart Van Assche <bvanassche@acm.org>
Wed, 17 Apr 2019 21:44:25 +0000 (14:44 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 29 Apr 2019 21:24:50 +0000 (17:24 -0400)
commite8a5a67582401c91ba4b9a98fba1d0b09eb72656
tree16e4abb84efc04039aec9d9ce7781b067c013a30
parent3d7e3f76a7758d527609bb41e1d78ae6860f7852
scsi: qla2xxx: Fix use-after-free issues in qla2xxx_qpair_sp_free_dma()

The current order for freeing memory is as follows:
- struct crc_context itself.
- struct crc_context member pointers.

Change the freeing order into the following:
- struct crc_context member pointers.
- struct crc_context itself.

Detected by Coverity.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Fixes: c600b5a6314c ("scsi: qla2xxx: Fix DMA error when the DIF sg buffer crosses 4GB boundary") # v5.1-rc1.
Fixes: 60446cc8b45a ("scsi: qla2xxx: Add multiple queue pair functionality.") # v4.10.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_os.c