]> git.baikalelectronics.ru Git - kernel.git/commit
drivers: net: ethernet: ti: davinci_emac: fix usage of cpdma_check_free_tx_desc()
authorMugunthan V N <mugunthanvnm@ti.com>
Fri, 15 Mar 2013 04:10:16 +0000 (04:10 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 17 Mar 2013 16:18:44 +0000 (12:18 -0400)
commite89b64116b53a46d59605aefbef693510169041a
tree2694727c1c95e26ff9f471d5f986baec8fef541b
parenta78e371bc4fe9d4ae13f7f9b7792ffb153efa41f
drivers: net: ethernet: ti: davinci_emac: fix usage of cpdma_check_free_tx_desc()

Fix which was done in the following commit in cpsw driver has
to be taken forward to davinci emac driver as well.

commit 0a11ea7516834bf50502c60af87d470ca5873843
Author: Daniel Mack <zonque@gmail.com>
Date:   Tue Mar 12 06:31:19 2013 +0000

    net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc()

    Commit 35099cc55c ("net: ethernet: davinci_cpdma: Add boundary for rx
    and tx descriptors") introduced a function to check the current
    allocation state of tx packets. The return value is taken into account
    to stop the netqork queue on the adapter in case there are no free
    slots.

    However, cpdma_check_free_tx_desc() returns 'true' if there is room in
    the bitmap, not 'false', so the usage of the function is wrong.

Reported-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
Tested-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/davinci_emac.c