]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amdgpu: Fix signedness bug in __amdgpu_eeprom_xfer()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 3 Jul 2021 09:44:57 +0000 (12:44 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 8 Jul 2021 19:18:14 +0000 (15:18 -0400)
commite87fd8004191023e900c5e4184ea45024bb8c58f
tree6a266e4074f287ca75910e314f4810d6bd7716cf
parenta79410217738e052d51ad079a530d6fd7793fd59
drm/amdgpu: Fix signedness bug in __amdgpu_eeprom_xfer()

The i2c_transfer() function returns negatives or else the number of
messages transferred.  This code does not work because ARRAY_SIZE()
is type size_t and so that means negative values of "r" are type
promoted to high positive values which are greater than the ARRAY_SIZE().

Fix this by changing the < to != which works regardless of type
promotion.

Fixes: c43338d39e1109 ("drm/amdgpu: Fixes to the AMDGPU EEPROM driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_eeprom.c