]> git.baikalelectronics.ru Git - kernel.git/commit
Input: joydev - prevent potential read overflow in ioctl
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 17 Feb 2021 20:21:10 +0000 (12:21 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 19 Feb 2021 19:02:16 +0000 (11:02 -0800)
commite87cdafb472e8ccce8314ec527479f73076ee3ea
tree30f4dd514f60efc32de464610152f11b75e92354
parente0ca37de1ef7a57c30ae932912e0593877472a67
Input: joydev - prevent potential read overflow in ioctl

The problem here is that "len" might be less than "joydev->nabs" so the
loops which verfy abspam[i] and keypam[] might read beyond the buffer.

Fixes: 2e9f4bbf3889 ("Input: joydev - validate axis/button maps before clobbering current ones")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YCyzR8WvFRw4HWw6@mwanda
[dtor: additional check for len being even in joydev_handle_JSIOCSBTNMAP]
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joydev.c