]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: firewire-lib: continue packet processing at detecting wrong CIP headers
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 11 Oct 2015 13:33:50 +0000 (22:33 +0900)
committerTakashi Iwai <tiwai@suse.de>
Sun, 11 Oct 2015 16:14:01 +0000 (18:14 +0200)
commite862aec280954715d9ddb5b95bcfdbd8b86544d7
treeb75197f077feaef197fda7aeacd7e26785473baa
parentcb870efdc7538cca134b73db5fb6eddf78588e11
ALSA: firewire-lib: continue packet processing at detecting wrong CIP headers

In firewire-lib, isochronous packet streaming is stopped when detecting
wrong value for FMT field of CIP headers. Although this is appropriate
to IEC 61883-1 and 6, some BeBoB based devices with vendors' customization
use invalid value to FMT field of CIP headers in the beginning of
streaming.

$ journalctl
  snd-bebob fw1.0: Detect unexpected protocol: 01000000 8000ffff

I got this log with M-Audio FireWire 1814. In this line, the value of FMT
field is 0x00, while it should be 0x10 in usual AMDTP.

Except for the beginning, these devices continue to transfer packets with
valid value for FMT field, except for the beginning. Therefore, in this
case, firewire-lib should continue to process packets. The former
implementation of firewire-lib performs it.

This commit loosens the handling of wrong value, to continue packet
processing in the case.

Fixes: 296362b0730e ('ALSA: firewire-lib: add support arbitrary value for fmt/fdf fields in CIP header')
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/amdtp-stream.c