]> git.baikalelectronics.ru Git - kernel.git/commit
netpoll: do not test NAPI_STATE_SCHED in poll_one_napi()
authorEric Dumazet <edumazet@google.com>
Thu, 27 Sep 2018 16:31:51 +0000 (09:31 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 28 Sep 2018 18:12:28 +0000 (11:12 -0700)
commite81d94ccb9add9943e41316c8d7aea5c1669c0a7
tree96dce225e61d6f78fd539c2f5b6e443dd4bec041
parent34eafcd423c1fa40bca050a5a8e633cc39f726f2
netpoll: do not test NAPI_STATE_SCHED in poll_one_napi()

Since we do no longer require NAPI drivers to provide
an ndo_poll_controller(), napi_schedule() has not been done
before poll_one_napi() invocation.

So testing NAPI_STATE_SCHED is likely to cause early returns.

While we are at it, remove outdated comment.

Note to future bisections : This change might surface prior
bugs in drivers. See commit 11fd10c2373a ("bnxt_en: Fix TX
timeout during netpoll.") for one occurrence.

Fixes: 12b3c16a7c5b ("netpoll: make ndo_poll_controller() optional")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Song Liu <songliubraving@fb.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/netpoll.c