]> git.baikalelectronics.ru Git - kernel.git/commit
[media] horus3a: don't use variable length arrays
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 11 Aug 2015 18:29:54 +0000 (15:29 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 11 Aug 2015 18:41:23 +0000 (15:41 -0300)
commite7f70e2f9f8bac1c22ea4b429cfbe49be605afe5
tree1a950da617bb1ae8e83598f4f3c0563ec9b0a743
parentb2005a858352c33ae55371e8d2a6d85b10c22c08
[media] horus3a: don't use variable length arrays

The Linux stack is short; we need to be able to count the number
of bytes used at stack on each function. So, we don't like to
use variable-length arrays, as complained by smatch:
drivers/media/dvb-frontends/horus3a.c:57:19: warning: Variable length array is used.

The max usecase of the driver seems to be 5 bytes + 1 for the
register.

So, let's be safe and allocate 6 bytes for the write buffer.
This should be enough to cover all cases. If not, let's print
an error message.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/horus3a.c