Bluetooth: Fix not cleanup led when bt_init fails
authorChen Zhongjin <chenzhongjin@huawei.com>
Tue, 29 Nov 2022 09:25:56 +0000 (17:25 +0800)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 2 Dec 2022 21:09:31 +0000 (13:09 -0800)
commite7efdee890d05a1b1a64f012ded0fa8d36ae340e
tree80d99abf898a0311756025714e649a9c7a7c689e
parent4c09e583d91e0ee002bf0d21779b625d04492745
Bluetooth: Fix not cleanup led when bt_init fails

bt_init() calls bt_leds_init() to register led, but if it fails later,
bt_leds_cleanup() is not called to unregister it.

This can cause panic if the argument "bluetooth-power" in text is freed
and then another led_trigger_register() tries to access it:

BUG: unable to handle page fault for address: ffffffffc06d3bc0
RIP: 0010:strcmp+0xc/0x30
  Call Trace:
    <TASK>
    led_trigger_register+0x10d/0x4f0
    led_trigger_register_simple+0x7d/0x100
    bt_init+0x39/0xf7 [bluetooth]
    do_one_initcall+0xd0/0x4e0

Fixes: 0c2bc0de821e ("Bluetooth: Add combined LED trigger for controller power")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/af_bluetooth.c