]> git.baikalelectronics.ru Git - kernel.git/commit
regulator: fixed: Default enable high on DT regulators
authorLinus Walleij <linus.walleij@linaro.org>
Mon, 1 Oct 2018 20:43:46 +0000 (22:43 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 2 Oct 2018 13:16:00 +0000 (14:16 +0100)
commite7db18ff21c0124468126b8989951a4fb641f80e
tree1d374f80eaf53455b78529f82c182dca4265cf35
parent38b62286348baa5a91f4ea89b33eb1f735bb2529
regulator: fixed: Default enable high on DT regulators

commit 3bfbc244c15a
("regulator: fixed: Convert to use GPIO descriptor only")
switched to use gpiod_get() to look up the regulator from the
gpiolib core whether that is device tree or boardfile.

This meant that we activate the code in
4585f4b2aa57 ("gpio: of: Add special quirk to parse regulator flags")
which means the descriptors coming from the device tree already
have the right inversion and open drain semantics set up from
the gpiolib core.

As the fixed regulator was inspected again we got the
inverted inversion and things broke.

Fix it by ignoring the config in the device tree for now: the
later patches in the series will push all inversion handling
over to the gpiolib core and set it up properly in the
boardfiles for legacy devices, but I did not finish that
for this kernel cycle.

Fixes: commit 3bfbc244c15a ("regulator: fixed: Convert to use GPIO descriptor only")
Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
Reported-by: Fabio Estevam <festevam@gmail.com>
Reported-by: John Stultz <john.stultz@linaro.org>
Reported-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/fixed.c